Repository navigation
TypedPython: TSan test ignores mimalloc block reuse - #347
Merged
Merged
Conversation
… block The intermittent Linux failure pairs tp_traced reading a thread state with _mi_malloc_generic's memset of the same memory after that thread exited; the free and reuse happen in the uninstrumented allocator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_threadsanitizer_reports_nothing_on_the_extension failed intermittently on ubuntu (runs 40584823089, 40591670584): one access is
_mi_malloc_genericmemset in libpython, the othertp_tracedreading a PyThreadState of a thread that has since exited. Free and reuse are both inside the uninstrumented allocator, so TSan cannot order them. The filter now drops reports whose access is mimalloc initialising a block; reports where both accesses are the extension's still count.